added const and constexpr refacotred build options

This commit is contained in:
2024-09-23 10:46:32 -07:00
parent ee68574542
commit 46e7a82f1d
5 changed files with 97 additions and 91 deletions

View File

@@ -5,20 +5,26 @@ project(omath)
set(CMAKE_CXX_STANDARD 26) set(CMAKE_CXX_STANDARD 26)
option(BUILD_TESTS "Build unit tests" ON) option(OMATH_BUILD_TESTS "Build unit tests" ON)
option(THREAT_WARNING_AS_ERROR "Set highest level of warnings and force compiler to threat them as errors" ON) option(OMATH_THREAT_WARNING_AS_ERROR "Set highest level of warnings and force compiler to threat them as errors" ON)
option(OMATH_BUILD_AS_SHARED_LIBRARY "Build Omath as .so\\.dll." OFF)
if (OMATH_BUILD_AS_SHARED_LIBRARY)
add_library(omath SHARED source/Vector3.cpp)
else()
add_library(omath STATIC source/Vector3.cpp) add_library(omath STATIC source/Vector3.cpp)
endif()
add_subdirectory(source) add_subdirectory(source)
add_subdirectory(extlibs) add_subdirectory(extlibs)
if(BUILD_TESTS) if(OMATH_BUILD_TESTS)
add_subdirectory(tests) add_subdirectory(tests)
endif () endif ()
if (WIN32 AND THREAT_WARNING_AS_ERROR) if (WIN32 AND OMATH_THREAT_WARNING_AS_ERROR)
target_compile_options(omath PRIVATE /W4 /WX) target_compile_options(omath PRIVATE /W4 /WX)
elseif(UNIX AND THREAT_WARNING_AS_ERROR) elseif(UNIX AND OMATH_THREAT_WARNING_AS_ERROR)
target_compile_options(omath PRIVATE -Wall -Wextra -Wpedantic) target_compile_options(omath PRIVATE -Wall -Wextra -Wpedantic)
endif() endif()

View File

@@ -146,7 +146,7 @@ namespace omath
return {x * v.x, y * v.y, z * v.z}; return {x * v.x, y * v.y, z * v.z};
} }
[[nodiscard]] constexpr Vector3 operator/(float fl) const [[nodiscard]] constexpr Vector3 operator/(const float fl) const
{ {
return {x / fl, y / fl, z / fl}; return {x / fl, y / fl, z / fl};
} }

View File

@@ -24,7 +24,7 @@ protected:
// Test constructors // Test constructors
TEST_F(UnitTestMatrix, Constructor_Size) TEST_F(UnitTestMatrix, Constructor_Size)
{ {
Matrix m(3, 3); const Matrix m(3, 3);
EXPECT_EQ(m.RowCount(), 3); EXPECT_EQ(m.RowCount(), 3);
EXPECT_EQ(m.ColumnsCount(), 3); EXPECT_EQ(m.ColumnsCount(), 3);
} }
@@ -90,19 +90,19 @@ TEST_F(UnitTestMatrix, Transpose)
TEST_F(UnitTestMatrix, Determinant) TEST_F(UnitTestMatrix, Determinant)
{ {
float det = m2.Determinant(); const float det = m2.Determinant();
EXPECT_FLOAT_EQ(det, -2.0f); EXPECT_FLOAT_EQ(det, -2.0f);
} }
TEST_F(UnitTestMatrix, Minor) TEST_F(UnitTestMatrix, Minor)
{ {
float minor = m2.Minor(0, 0); const float minor = m2.Minor(0, 0);
EXPECT_FLOAT_EQ(minor, 4.0f); EXPECT_FLOAT_EQ(minor, 4.0f);
} }
TEST_F(UnitTestMatrix, AlgComplement) TEST_F(UnitTestMatrix, AlgComplement)
{ {
float algComp = m2.AlgComplement(0, 0); const float algComp = m2.AlgComplement(0, 0);
EXPECT_FLOAT_EQ(algComp, 4.0f); EXPECT_FLOAT_EQ(algComp, 4.0f);
} }
@@ -116,7 +116,7 @@ TEST_F(UnitTestMatrix, Strip)
TEST_F(UnitTestMatrix, ProjectionMatrix) TEST_F(UnitTestMatrix, ProjectionMatrix)
{ {
Matrix proj = Matrix::ProjectionMatrix(45.0f, 1.33f, 0.1f, 100.0f); const Matrix proj = Matrix::ProjectionMatrix(45.0f, 1.33f, 0.1f, 100.0f);
EXPECT_EQ(proj.RowCount(), 4); EXPECT_EQ(proj.RowCount(), 4);
EXPECT_EQ(proj.ColumnsCount(), 4); EXPECT_EQ(proj.ColumnsCount(), 4);
// Further checks on projection matrix elements could be added // Further checks on projection matrix elements could be added
@@ -132,7 +132,7 @@ TEST_F(UnitTestMatrix, Set)
TEST_F(UnitTestMatrix, Sum) TEST_F(UnitTestMatrix, Sum)
{ {
float sum = m2.Sum(); const float sum = m2.Sum();
EXPECT_FLOAT_EQ(sum, 10.0f); EXPECT_FLOAT_EQ(sum, 10.0f);
} }
@@ -145,7 +145,7 @@ TEST_F(UnitTestMatrix, Clear)
TEST_F(UnitTestMatrix, ToString) TEST_F(UnitTestMatrix, ToString)
{ {
std::string str = m2.ToSrtring(); const std::string str = m2.ToSrtring();
EXPECT_FALSE(str.empty()); EXPECT_FALSE(str.empty());
} }

View File

@@ -198,14 +198,14 @@ TEST_F(UnitTestVector2, Length)
TEST_F(UnitTestVector2, Length_ZeroVector) TEST_F(UnitTestVector2, Length_ZeroVector)
{ {
Vector2 v_zero(0.0f, 0.0f); constexpr Vector2 v_zero(0.0f, 0.0f);
const float length = v_zero.Length(); const float length = v_zero.Length();
EXPECT_FLOAT_EQ(length, 0.0f); EXPECT_FLOAT_EQ(length, 0.0f);
} }
TEST_F(UnitTestVector2, Length_LargeValues) TEST_F(UnitTestVector2, Length_LargeValues)
{ {
Vector2 v_large(FLT_MAX, FLT_MAX); constexpr Vector2 v_large(FLT_MAX, FLT_MAX);
const float length = v_large.Length(); const float length = v_large.Length();
EXPECT_TRUE(std::isinf(length)); EXPECT_TRUE(std::isinf(length));
} }
@@ -261,8 +261,8 @@ TEST_F(UnitTestVector2, Normalized)
TEST_F(UnitTestVector2, Normalized_ZeroVector) TEST_F(UnitTestVector2, Normalized_ZeroVector)
{ {
Vector2 v_zero(0.0f, 0.0f); constexpr Vector2 v_zero(0.0f, 0.0f);
Vector2 v_norm = v_zero.Normalized(); const Vector2 v_norm = v_zero.Normalized();
EXPECT_FLOAT_EQ(v_norm.x, 0.0f); EXPECT_FLOAT_EQ(v_norm.x, 0.0f);
EXPECT_FLOAT_EQ(v_norm.y, 0.0f); EXPECT_FLOAT_EQ(v_norm.y, 0.0f);
} }
@@ -270,7 +270,7 @@ TEST_F(UnitTestVector2, Normalized_ZeroVector)
// Test AsTuple method // Test AsTuple method
TEST_F(UnitTestVector2, AsTuple) TEST_F(UnitTestVector2, AsTuple)
{ {
auto tuple = v1.AsTuple(); const auto tuple = v1.AsTuple();
EXPECT_FLOAT_EQ(std::get<0>(tuple), v1.x); EXPECT_FLOAT_EQ(std::get<0>(tuple), v1.x);
EXPECT_FLOAT_EQ(std::get<1>(tuple), v1.y); EXPECT_FLOAT_EQ(std::get<1>(tuple), v1.y);
} }
@@ -278,9 +278,9 @@ TEST_F(UnitTestVector2, AsTuple)
// Test division by zero // Test division by zero
TEST_F(UnitTestVector2, DivisionOperator_DivideByZero) TEST_F(UnitTestVector2, DivisionOperator_DivideByZero)
{ {
Vector2 v(1.0f, 2.0f); constexpr Vector2 v(1.0f, 2.0f);
float zero = 0.0f; constexpr float zero = 0.0f;
Vector2 result = v / zero; const Vector2 result = v / zero;
EXPECT_TRUE(std::isinf(result.x) || std::isnan(result.x)); EXPECT_TRUE(std::isinf(result.x) || std::isnan(result.x));
EXPECT_TRUE(std::isinf(result.y) || std::isnan(result.y)); EXPECT_TRUE(std::isinf(result.y) || std::isnan(result.y));
} }
@@ -288,7 +288,7 @@ TEST_F(UnitTestVector2, DivisionOperator_DivideByZero)
TEST_F(UnitTestVector2, DivisionAssignmentOperator_DivideByZero) TEST_F(UnitTestVector2, DivisionAssignmentOperator_DivideByZero)
{ {
Vector2 v(1.0f, 2.0f); Vector2 v(1.0f, 2.0f);
float zero = 0.0f; constexpr float zero = 0.0f;
v /= zero; v /= zero;
EXPECT_TRUE(std::isinf(v.x) || std::isnan(v.x)); EXPECT_TRUE(std::isinf(v.x) || std::isnan(v.x));
EXPECT_TRUE(std::isinf(v.y) || std::isnan(v.y)); EXPECT_TRUE(std::isinf(v.y) || std::isnan(v.y));
@@ -297,7 +297,7 @@ TEST_F(UnitTestVector2, DivisionAssignmentOperator_DivideByZero)
TEST_F(UnitTestVector2, DivisionAssignmentOperator_VectorWithZero) TEST_F(UnitTestVector2, DivisionAssignmentOperator_VectorWithZero)
{ {
Vector2 v(1.0f, 2.0f); Vector2 v(1.0f, 2.0f);
Vector2 v_zero(0.0f, 1.0f); constexpr Vector2 v_zero(0.0f, 1.0f);
v /= v_zero; v /= v_zero;
EXPECT_TRUE(std::isinf(v.x) || std::isnan(v.x)); EXPECT_TRUE(std::isinf(v.x) || std::isnan(v.x));
EXPECT_FLOAT_EQ(v.y, 2.0f / 1.0f); EXPECT_FLOAT_EQ(v.y, 2.0f / 1.0f);
@@ -306,16 +306,16 @@ TEST_F(UnitTestVector2, DivisionAssignmentOperator_VectorWithZero)
// Test operations with infinity and NaN // Test operations with infinity and NaN
TEST_F(UnitTestVector2, Operator_WithInfinity) TEST_F(UnitTestVector2, Operator_WithInfinity)
{ {
Vector2 v_inf(INFINITY, INFINITY); constexpr Vector2 v_inf(INFINITY, INFINITY);
Vector2 result = v1 + v_inf; const Vector2 result = v1 + v_inf;
EXPECT_TRUE(std::isinf(result.x)); EXPECT_TRUE(std::isinf(result.x));
EXPECT_TRUE(std::isinf(result.y)); EXPECT_TRUE(std::isinf(result.y));
} }
TEST_F(UnitTestVector2, Operator_WithNaN) TEST_F(UnitTestVector2, Operator_WithNaN)
{ {
Vector2 v_nan(NAN, NAN); constexpr Vector2 v_nan(NAN, NAN);
Vector2 result = v1 + v_nan; const Vector2 result = v1 + v_nan;
EXPECT_TRUE(std::isnan(result.x)); EXPECT_TRUE(std::isnan(result.x));
EXPECT_TRUE(std::isnan(result.y)); EXPECT_TRUE(std::isnan(result.y));
} }
@@ -323,16 +323,16 @@ TEST_F(UnitTestVector2, Operator_WithNaN)
// Test negative values in arithmetic operations // Test negative values in arithmetic operations
TEST_F(UnitTestVector2, AdditionOperator_NegativeValues) TEST_F(UnitTestVector2, AdditionOperator_NegativeValues)
{ {
Vector2 v_neg(-1.0f, -2.0f); constexpr Vector2 v_neg(-1.0f, -2.0f);
Vector2 result = v1 + v_neg; const Vector2 result = v1 + v_neg;
EXPECT_FLOAT_EQ(result.x, 0.0f); EXPECT_FLOAT_EQ(result.x, 0.0f);
EXPECT_FLOAT_EQ(result.y, 0.0f); EXPECT_FLOAT_EQ(result.y, 0.0f);
} }
TEST_F(UnitTestVector2, SubtractionOperator_NegativeValues) TEST_F(UnitTestVector2, SubtractionOperator_NegativeValues)
{ {
Vector2 v_neg(-1.0f, -2.0f); constexpr Vector2 v_neg(-1.0f, -2.0f);
Vector2 result = v1 - v_neg; const Vector2 result = v1 - v_neg;
EXPECT_FLOAT_EQ(result.x, 2.0f); EXPECT_FLOAT_EQ(result.x, 2.0f);
EXPECT_FLOAT_EQ(result.y, 4.0f); EXPECT_FLOAT_EQ(result.y, 4.0f);
} }
@@ -340,8 +340,8 @@ TEST_F(UnitTestVector2, SubtractionOperator_NegativeValues)
// Test negation of zero vector // Test negation of zero vector
TEST_F(UnitTestVector2, NegationOperator_ZeroVector) TEST_F(UnitTestVector2, NegationOperator_ZeroVector)
{ {
Vector2 v_zero(0.0f, 0.0f); constexpr Vector2 v_zero(0.0f, 0.0f);
Vector2 result = -v_zero; constexpr Vector2 result = -v_zero;
EXPECT_FLOAT_EQ(result.x, -0.0f); EXPECT_FLOAT_EQ(result.x, -0.0f);
EXPECT_FLOAT_EQ(result.y, -0.0f); EXPECT_FLOAT_EQ(result.y, -0.0f);
} }

View File

@@ -26,7 +26,7 @@ protected:
// Test constructor and default values // Test constructor and default values
TEST_F(UnitTestVector3, Constructor_Default) TEST_F(UnitTestVector3, Constructor_Default)
{ {
Vector3 v; constexpr Vector3 v;
EXPECT_FLOAT_EQ(v.x, 0.0f); EXPECT_FLOAT_EQ(v.x, 0.0f);
EXPECT_FLOAT_EQ(v.y, 0.0f); EXPECT_FLOAT_EQ(v.y, 0.0f);
EXPECT_FLOAT_EQ(v.z, 0.0f); EXPECT_FLOAT_EQ(v.z, 0.0f);
@@ -34,7 +34,7 @@ TEST_F(UnitTestVector3, Constructor_Default)
TEST_F(UnitTestVector3, Constructor_Values) TEST_F(UnitTestVector3, Constructor_Values)
{ {
Vector3 v(1.0f, 2.0f, 3.0f); constexpr Vector3 v(1.0f, 2.0f, 3.0f);
EXPECT_FLOAT_EQ(v.x, 1.0f); EXPECT_FLOAT_EQ(v.x, 1.0f);
EXPECT_FLOAT_EQ(v.y, 2.0f); EXPECT_FLOAT_EQ(v.y, 2.0f);
EXPECT_FLOAT_EQ(v.z, 3.0f); EXPECT_FLOAT_EQ(v.z, 3.0f);
@@ -43,14 +43,14 @@ TEST_F(UnitTestVector3, Constructor_Values)
// Test equality operators // Test equality operators
TEST_F(UnitTestVector3, EqualityOperator) TEST_F(UnitTestVector3, EqualityOperator)
{ {
Vector3 v3(1.0f, 2.0f, 3.0f); constexpr Vector3 v3(1.0f, 2.0f, 3.0f);
EXPECT_TRUE(v1 == v3); EXPECT_TRUE(v1 == v3);
EXPECT_FALSE(v1 == v2); EXPECT_FALSE(v1 == v2);
} }
TEST_F(UnitTestVector3, InequalityOperator) TEST_F(UnitTestVector3, InequalityOperator)
{ {
Vector3 v3(1.0f, 2.0f, 3.0f); constexpr Vector3 v3(1.0f, 2.0f, 3.0f);
EXPECT_FALSE(v1 != v3); EXPECT_FALSE(v1 != v3);
EXPECT_TRUE(v1 != v2); EXPECT_TRUE(v1 != v2);
} }
@@ -58,7 +58,7 @@ TEST_F(UnitTestVector3, InequalityOperator)
// Test arithmetic operators // Test arithmetic operators
TEST_F(UnitTestVector3, AdditionOperator) TEST_F(UnitTestVector3, AdditionOperator)
{ {
Vector3 v3 = Vector3(1.0f, 2.0f, 3.0f) + Vector3(4.0f, 5.0f, 6.0f); constexpr Vector3 v3 = Vector3(1.0f, 2.0f, 3.0f) + Vector3(4.0f, 5.0f, 6.0f);
EXPECT_FLOAT_EQ(v3.x, 5.0f); EXPECT_FLOAT_EQ(v3.x, 5.0f);
EXPECT_FLOAT_EQ(v3.y, 7.0f); EXPECT_FLOAT_EQ(v3.y, 7.0f);
EXPECT_FLOAT_EQ(v3.z, 9.0f); EXPECT_FLOAT_EQ(v3.z, 9.0f);
@@ -66,7 +66,7 @@ TEST_F(UnitTestVector3, AdditionOperator)
TEST_F(UnitTestVector3, SubtractionOperator) TEST_F(UnitTestVector3, SubtractionOperator)
{ {
Vector3 v3 = Vector3(4.0f, 5.0f, 6.0f) - Vector3(1.0f, 2.0f, 3.0f); constexpr Vector3 v3 = Vector3(4.0f, 5.0f, 6.0f) - Vector3(1.0f, 2.0f, 3.0f);
EXPECT_FLOAT_EQ(v3.x, 3.0f); EXPECT_FLOAT_EQ(v3.x, 3.0f);
EXPECT_FLOAT_EQ(v3.y, 3.0f); EXPECT_FLOAT_EQ(v3.y, 3.0f);
EXPECT_FLOAT_EQ(v3.z, 3.0f); EXPECT_FLOAT_EQ(v3.z, 3.0f);
@@ -74,7 +74,7 @@ TEST_F(UnitTestVector3, SubtractionOperator)
TEST_F(UnitTestVector3, MultiplicationOperator_Scalar) TEST_F(UnitTestVector3, MultiplicationOperator_Scalar)
{ {
Vector3 v3 = Vector3(1.0f, 2.0f, 3.0f) * 2.0f; constexpr Vector3 v3 = Vector3(1.0f, 2.0f, 3.0f) * 2.0f;
EXPECT_FLOAT_EQ(v3.x, 2.0f); EXPECT_FLOAT_EQ(v3.x, 2.0f);
EXPECT_FLOAT_EQ(v3.y, 4.0f); EXPECT_FLOAT_EQ(v3.y, 4.0f);
EXPECT_FLOAT_EQ(v3.z, 6.0f); EXPECT_FLOAT_EQ(v3.z, 6.0f);
@@ -82,7 +82,7 @@ TEST_F(UnitTestVector3, MultiplicationOperator_Scalar)
TEST_F(UnitTestVector3, MultiplicationOperator_Vector) TEST_F(UnitTestVector3, MultiplicationOperator_Vector)
{ {
Vector3 v3 = Vector3(1.0f, 2.0f, 3.0f) * Vector3(4.0f, 5.0f, 6.0f); constexpr auto v3 = Vector3(1.0f, 2.0f, 3.0f) * Vector3(4.0f, 5.0f, 6.0f);
EXPECT_FLOAT_EQ(v3.x, 4.0f); EXPECT_FLOAT_EQ(v3.x, 4.0f);
EXPECT_FLOAT_EQ(v3.y, 10.0f); EXPECT_FLOAT_EQ(v3.y, 10.0f);
EXPECT_FLOAT_EQ(v3.z, 18.0f); EXPECT_FLOAT_EQ(v3.z, 18.0f);
@@ -90,7 +90,7 @@ TEST_F(UnitTestVector3, MultiplicationOperator_Vector)
TEST_F(UnitTestVector3, DivisionOperator_Scalar) TEST_F(UnitTestVector3, DivisionOperator_Scalar)
{ {
Vector3 v3 = Vector3(4.0f, 5.0f, 6.0f) / 2.0f; constexpr auto v3 = Vector3(4.0f, 5.0f, 6.0f) / 2.0f;
EXPECT_FLOAT_EQ(v3.x, 2.0f); EXPECT_FLOAT_EQ(v3.x, 2.0f);
EXPECT_FLOAT_EQ(v3.y, 2.5f); EXPECT_FLOAT_EQ(v3.y, 2.5f);
EXPECT_FLOAT_EQ(v3.z, 3.0f); EXPECT_FLOAT_EQ(v3.z, 3.0f);
@@ -98,7 +98,7 @@ TEST_F(UnitTestVector3, DivisionOperator_Scalar)
TEST_F(UnitTestVector3, DivisionOperator_Vector) TEST_F(UnitTestVector3, DivisionOperator_Vector)
{ {
Vector3 v3 = Vector3(4.0f, 5.0f, 6.0f) / Vector3(1.0f, 2.0f, 3.0f); constexpr auto v3 = Vector3(4.0f, 5.0f, 6.0f) / Vector3(1.0f, 2.0f, 3.0f);
EXPECT_FLOAT_EQ(v3.x, 4.0f); EXPECT_FLOAT_EQ(v3.x, 4.0f);
EXPECT_FLOAT_EQ(v3.y, 2.5f); EXPECT_FLOAT_EQ(v3.y, 2.5f);
EXPECT_FLOAT_EQ(v3.z, 2.0f); EXPECT_FLOAT_EQ(v3.z, 2.0f);
@@ -155,7 +155,7 @@ TEST_F(UnitTestVector3, DivisionAssignmentOperator_Vector)
TEST_F(UnitTestVector3, NegationOperator) TEST_F(UnitTestVector3, NegationOperator)
{ {
Vector3 v3 = -Vector3(1.0f, 2.0f, 3.0f); constexpr auto v3 = -Vector3(1.0f, 2.0f, 3.0f);
EXPECT_FLOAT_EQ(v3.x, -1.0f); EXPECT_FLOAT_EQ(v3.x, -1.0f);
EXPECT_FLOAT_EQ(v3.y, -2.0f); EXPECT_FLOAT_EQ(v3.y, -2.0f);
EXPECT_FLOAT_EQ(v3.z, -3.0f); EXPECT_FLOAT_EQ(v3.z, -3.0f);
@@ -164,25 +164,25 @@ TEST_F(UnitTestVector3, NegationOperator)
// Test other member functions // Test other member functions
TEST_F(UnitTestVector3, DistToSqr) TEST_F(UnitTestVector3, DistToSqr)
{ {
float distSqr = Vector3(1.0f, 2.0f, 3.0f).DistToSqr(Vector3(4.0f, 5.0f, 6.0f)); constexpr auto distSqr = Vector3(1.0f, 2.0f, 3.0f).DistToSqr(Vector3(4.0f, 5.0f, 6.0f));
EXPECT_FLOAT_EQ(distSqr, 27.0f); EXPECT_FLOAT_EQ(distSqr, 27.0f);
} }
TEST_F(UnitTestVector3, DotProduct) TEST_F(UnitTestVector3, DotProduct)
{ {
float dot = Vector3(1.0f, 2.0f, 3.0f).Dot(Vector3(4.0f, 5.0f, 6.0f)); constexpr auto dot = Vector3(1.0f, 2.0f, 3.0f).Dot(Vector3(4.0f, 5.0f, 6.0f));
EXPECT_FLOAT_EQ(dot, 32.0f); EXPECT_FLOAT_EQ(dot, 32.0f);
} }
TEST_F(UnitTestVector3, LengthSqr) TEST_F(UnitTestVector3, LengthSqr)
{ {
float lengthSqr = Vector3(1.0f, 2.0f, 3.0f).LengthSqr(); constexpr auto lengthSqr = Vector3(1.0f, 2.0f, 3.0f).LengthSqr();
EXPECT_FLOAT_EQ(lengthSqr, 14.0f); EXPECT_FLOAT_EQ(lengthSqr, 14.0f);
} }
TEST_F(UnitTestVector3, Abs) TEST_F(UnitTestVector3, Abs)
{ {
Vector3 v3 = Vector3(-1.0f, -2.0f, -3.0f); auto v3 = Vector3(-1.0f, -2.0f, -3.0f);
v3.Abs(); v3.Abs();
EXPECT_FLOAT_EQ(v3.x, 1.0f); EXPECT_FLOAT_EQ(v3.x, 1.0f);
EXPECT_FLOAT_EQ(v3.y, 2.0f); EXPECT_FLOAT_EQ(v3.y, 2.0f);
@@ -191,19 +191,19 @@ TEST_F(UnitTestVector3, Abs)
TEST_F(UnitTestVector3, Sum) TEST_F(UnitTestVector3, Sum)
{ {
float sum = Vector3(1.0f, 2.0f, 3.0f).Sum(); constexpr auto sum = Vector3(1.0f, 2.0f, 3.0f).Sum();
EXPECT_FLOAT_EQ(sum, 6.0f); EXPECT_FLOAT_EQ(sum, 6.0f);
} }
TEST_F(UnitTestVector3, Sum2D) TEST_F(UnitTestVector3, Sum2D)
{ {
float sum2D = Vector3(1.0f, 2.0f, 3.0f).Sum2D(); constexpr auto sum2D = Vector3(1.0f, 2.0f, 3.0f).Sum2D();
EXPECT_FLOAT_EQ(sum2D, 3.0f); EXPECT_FLOAT_EQ(sum2D, 3.0f);
} }
TEST_F(UnitTestVector3, CrossProduct) TEST_F(UnitTestVector3, CrossProduct)
{ {
Vector3 v3 = Vector3(1.0f, 2.0f, 3.0f).Cross(Vector3(4.0f, 5.0f, 6.0f)); constexpr Vector3 v3 = Vector3(1.0f, 2.0f, 3.0f).Cross(Vector3(4.0f, 5.0f, 6.0f));
EXPECT_FLOAT_EQ(v3.x, -3.0f); EXPECT_FLOAT_EQ(v3.x, -3.0f);
EXPECT_FLOAT_EQ(v3.y, 6.0f); EXPECT_FLOAT_EQ(v3.y, 6.0f);
EXPECT_FLOAT_EQ(v3.z, -3.0f); EXPECT_FLOAT_EQ(v3.z, -3.0f);
@@ -214,8 +214,8 @@ TEST_F(UnitTestVector3, CrossProduct)
// Test operations with zero vectors // Test operations with zero vectors
TEST_F(UnitTestVector3, Addition_WithZeroVector) TEST_F(UnitTestVector3, Addition_WithZeroVector)
{ {
Vector3 v_zero(0.0f, 0.0f, 0.0f); constexpr Vector3 v_zero(0.0f, 0.0f, 0.0f);
Vector3 result = v1 + v_zero; const Vector3 result = v1 + v_zero;
EXPECT_FLOAT_EQ(result.x, v1.x); EXPECT_FLOAT_EQ(result.x, v1.x);
EXPECT_FLOAT_EQ(result.y, v1.y); EXPECT_FLOAT_EQ(result.y, v1.y);
EXPECT_FLOAT_EQ(result.z, v1.z); EXPECT_FLOAT_EQ(result.z, v1.z);
@@ -223,8 +223,8 @@ TEST_F(UnitTestVector3, Addition_WithZeroVector)
TEST_F(UnitTestVector3, Subtraction_WithZeroVector) TEST_F(UnitTestVector3, Subtraction_WithZeroVector)
{ {
Vector3 v_zero(0.0f, 0.0f, 0.0f); constexpr Vector3 v_zero(0.0f, 0.0f, 0.0f);
Vector3 result = v1 - v_zero; const Vector3 result = v1 - v_zero;
EXPECT_FLOAT_EQ(result.x, v1.x); EXPECT_FLOAT_EQ(result.x, v1.x);
EXPECT_FLOAT_EQ(result.y, v1.y); EXPECT_FLOAT_EQ(result.y, v1.y);
EXPECT_FLOAT_EQ(result.z, v1.z); EXPECT_FLOAT_EQ(result.z, v1.z);
@@ -232,8 +232,8 @@ TEST_F(UnitTestVector3, Subtraction_WithZeroVector)
TEST_F(UnitTestVector3, Multiplication_WithZeroVector) TEST_F(UnitTestVector3, Multiplication_WithZeroVector)
{ {
Vector3 v_zero(0.0f, 0.0f, 0.0f); constexpr Vector3 v_zero(0.0f, 0.0f, 0.0f);
Vector3 result = v1 * v_zero; const Vector3 result = v1 * v_zero;
EXPECT_FLOAT_EQ(result.x, 0.0f); EXPECT_FLOAT_EQ(result.x, 0.0f);
EXPECT_FLOAT_EQ(result.y, 0.0f); EXPECT_FLOAT_EQ(result.y, 0.0f);
EXPECT_FLOAT_EQ(result.z, 0.0f); EXPECT_FLOAT_EQ(result.z, 0.0f);
@@ -241,8 +241,8 @@ TEST_F(UnitTestVector3, Multiplication_WithZeroVector)
TEST_F(UnitTestVector3, Division_ByZeroVector) TEST_F(UnitTestVector3, Division_ByZeroVector)
{ {
Vector3 v_zero(0.0f, 0.0f, 0.0f); constexpr Vector3 v_zero(0.0f, 0.0f, 0.0f);
Vector3 result = v1 / v_zero; const Vector3 result = v1 / v_zero;
EXPECT_TRUE(std::isinf(result.x) || std::isnan(result.x)); EXPECT_TRUE(std::isinf(result.x) || std::isnan(result.x));
EXPECT_TRUE(std::isinf(result.y) || std::isnan(result.y)); EXPECT_TRUE(std::isinf(result.y) || std::isnan(result.y));
EXPECT_TRUE(std::isinf(result.z) || std::isnan(result.z)); EXPECT_TRUE(std::isinf(result.z) || std::isnan(result.z));
@@ -250,8 +250,8 @@ TEST_F(UnitTestVector3, Division_ByZeroVector)
TEST_F(UnitTestVector3, Division_ByZeroScalar) TEST_F(UnitTestVector3, Division_ByZeroScalar)
{ {
float zero = 0.0f; constexpr float zero = 0.0f;
Vector3 result = v1 / zero; const Vector3 result = v1 / zero;
EXPECT_TRUE(std::isinf(result.x) || std::isnan(result.x)); EXPECT_TRUE(std::isinf(result.x) || std::isnan(result.x));
EXPECT_TRUE(std::isinf(result.y) || std::isnan(result.y)); EXPECT_TRUE(std::isinf(result.y) || std::isnan(result.y));
EXPECT_TRUE(std::isinf(result.z) || std::isnan(result.z)); EXPECT_TRUE(std::isinf(result.z) || std::isnan(result.z));
@@ -260,8 +260,8 @@ TEST_F(UnitTestVector3, Division_ByZeroScalar)
// Test operations with infinity // Test operations with infinity
TEST_F(UnitTestVector3, Addition_WithInfinity) TEST_F(UnitTestVector3, Addition_WithInfinity)
{ {
Vector3 v_inf(INFINITY, INFINITY, INFINITY); constexpr Vector3 v_inf(INFINITY, INFINITY, INFINITY);
Vector3 result = v1 + v_inf; const Vector3 result = v1 + v_inf;
EXPECT_TRUE(std::isinf(result.x)); EXPECT_TRUE(std::isinf(result.x));
EXPECT_TRUE(std::isinf(result.y)); EXPECT_TRUE(std::isinf(result.y));
EXPECT_TRUE(std::isinf(result.z)); EXPECT_TRUE(std::isinf(result.z));
@@ -269,8 +269,8 @@ TEST_F(UnitTestVector3, Addition_WithInfinity)
TEST_F(UnitTestVector3, Subtraction_WithInfinity) TEST_F(UnitTestVector3, Subtraction_WithInfinity)
{ {
Vector3 v_inf(INFINITY, INFINITY, INFINITY); constexpr Vector3 v_inf(INFINITY, INFINITY, INFINITY);
Vector3 result = v1 - v_inf; const Vector3 result = v1 - v_inf;
EXPECT_TRUE(std::isinf(result.x)); EXPECT_TRUE(std::isinf(result.x));
EXPECT_TRUE(std::isinf(result.y)); EXPECT_TRUE(std::isinf(result.y));
EXPECT_TRUE(std::isinf(result.z)); EXPECT_TRUE(std::isinf(result.z));
@@ -279,8 +279,8 @@ TEST_F(UnitTestVector3, Subtraction_WithInfinity)
// Test operations with NaN // Test operations with NaN
TEST_F(UnitTestVector3, Multiplication_WithNaN) TEST_F(UnitTestVector3, Multiplication_WithNaN)
{ {
Vector3 v_nan(NAN, NAN, NAN); constexpr Vector3 v_nan(NAN, NAN, NAN);
Vector3 result = v1 * v_nan; const Vector3 result = v1 * v_nan;
EXPECT_TRUE(std::isnan(result.x)); EXPECT_TRUE(std::isnan(result.x));
EXPECT_TRUE(std::isnan(result.y)); EXPECT_TRUE(std::isnan(result.y));
EXPECT_TRUE(std::isnan(result.z)); EXPECT_TRUE(std::isnan(result.z));
@@ -288,8 +288,8 @@ TEST_F(UnitTestVector3, Multiplication_WithNaN)
TEST_F(UnitTestVector3, Division_WithNaN) TEST_F(UnitTestVector3, Division_WithNaN)
{ {
Vector3 v_nan(NAN, NAN, NAN); constexpr Vector3 v_nan(NAN, NAN, NAN);
Vector3 result = v1 / v_nan; const Vector3 result = v1 / v_nan;
EXPECT_TRUE(std::isnan(result.x)); EXPECT_TRUE(std::isnan(result.x));
EXPECT_TRUE(std::isnan(result.y)); EXPECT_TRUE(std::isnan(result.y));
EXPECT_TRUE(std::isnan(result.z)); EXPECT_TRUE(std::isnan(result.z));
@@ -298,41 +298,41 @@ TEST_F(UnitTestVector3, Division_WithNaN)
// Test Length, Length2D, and Normalized // Test Length, Length2D, and Normalized
TEST_F(UnitTestVector3, Length) TEST_F(UnitTestVector3, Length)
{ {
float length = v1.Length(); const float length = v1.Length();
EXPECT_FLOAT_EQ(length, std::sqrt(14.0f)); EXPECT_FLOAT_EQ(length, std::sqrt(14.0f));
} }
TEST_F(UnitTestVector3, Length_ZeroVector) TEST_F(UnitTestVector3, Length_ZeroVector)
{ {
Vector3 v_zero(0.0f, 0.0f, 0.0f); constexpr Vector3 v_zero(0.0f, 0.0f, 0.0f);
float length = v_zero.Length(); const float length = v_zero.Length();
EXPECT_FLOAT_EQ(length, 0.0f); EXPECT_FLOAT_EQ(length, 0.0f);
} }
TEST_F(UnitTestVector3, Length_LargeValues) TEST_F(UnitTestVector3, Length_LargeValues)
{ {
Vector3 v_large(FLT_MAX, FLT_MAX, FLT_MAX); constexpr Vector3 v_large(FLT_MAX, FLT_MAX, FLT_MAX);
float length = v_large.Length(); const float length = v_large.Length();
EXPECT_TRUE(std::isinf(length)); EXPECT_TRUE(std::isinf(length));
} }
TEST_F(UnitTestVector3, Length2D) TEST_F(UnitTestVector3, Length2D)
{ {
float length2D = v1.Length2D(); const float length2D = v1.Length2D();
EXPECT_FLOAT_EQ(length2D, std::sqrt(5.0f)); EXPECT_FLOAT_EQ(length2D, std::sqrt(5.0f));
} }
TEST_F(UnitTestVector3, Normalized) TEST_F(UnitTestVector3, Normalized)
{ {
Vector3 v_norm = v1.Normalized(); const Vector3 v_norm = v1.Normalized();
float length = v_norm.Length(); const float length = v_norm.Length();
EXPECT_NEAR(length, 1.0f, 0.0001f); EXPECT_NEAR(length, 1.0f, 0.0001f);
} }
TEST_F(UnitTestVector3, Normalized_ZeroVector) TEST_F(UnitTestVector3, Normalized_ZeroVector)
{ {
Vector3 v_zero(0.0f, 0.0f, 0.0f); constexpr Vector3 v_zero(0.0f, 0.0f, 0.0f);
Vector3 v_norm = v_zero.Normalized(); const Vector3 v_norm = v_zero.Normalized();
EXPECT_FLOAT_EQ(v_norm.x, 0.0f); EXPECT_FLOAT_EQ(v_norm.x, 0.0f);
EXPECT_FLOAT_EQ(v_norm.y, 0.0f); EXPECT_FLOAT_EQ(v_norm.y, 0.0f);
EXPECT_FLOAT_EQ(v_norm.z, 0.0f); EXPECT_FLOAT_EQ(v_norm.z, 0.0f);
@@ -341,9 +341,9 @@ TEST_F(UnitTestVector3, Normalized_ZeroVector)
// Test Cross Product edge cases // Test Cross Product edge cases
TEST_F(UnitTestVector3, CrossProduct_ParallelVectors) TEST_F(UnitTestVector3, CrossProduct_ParallelVectors)
{ {
Vector3 v_a(1.0f, 2.0f, 3.0f); constexpr Vector3 v_a(1.0f, 2.0f, 3.0f);
Vector3 v_b = v_a * 2.0f; // Parallel to v_a constexpr Vector3 v_b = v_a * 2.0f; // Parallel to v_a
Vector3 cross = v_a.Cross(v_b); constexpr Vector3 cross = v_a.Cross(v_b);
EXPECT_FLOAT_EQ(cross.x, 0.0f); EXPECT_FLOAT_EQ(cross.x, 0.0f);
EXPECT_FLOAT_EQ(cross.y, 0.0f); EXPECT_FLOAT_EQ(cross.y, 0.0f);
EXPECT_FLOAT_EQ(cross.z, 0.0f); EXPECT_FLOAT_EQ(cross.z, 0.0f);
@@ -351,9 +351,9 @@ TEST_F(UnitTestVector3, CrossProduct_ParallelVectors)
TEST_F(UnitTestVector3, CrossProduct_OrthogonalVectors) TEST_F(UnitTestVector3, CrossProduct_OrthogonalVectors)
{ {
Vector3 v_a(1.0f, 0.0f, 0.0f); constexpr Vector3 v_a(1.0f, 0.0f, 0.0f);
Vector3 v_b(0.0f, 1.0f, 0.0f); constexpr Vector3 v_b(0.0f, 1.0f, 0.0f);
Vector3 cross = v_a.Cross(v_b); constexpr Vector3 cross = v_a.Cross(v_b);
EXPECT_FLOAT_EQ(cross.x, 0.0f); EXPECT_FLOAT_EQ(cross.x, 0.0f);
EXPECT_FLOAT_EQ(cross.y, 0.0f); EXPECT_FLOAT_EQ(cross.y, 0.0f);
EXPECT_FLOAT_EQ(cross.z, 1.0f); EXPECT_FLOAT_EQ(cross.z, 1.0f);
@@ -362,8 +362,8 @@ TEST_F(UnitTestVector3, CrossProduct_OrthogonalVectors)
// Test negative values // Test negative values
TEST_F(UnitTestVector3, Addition_NegativeValues) TEST_F(UnitTestVector3, Addition_NegativeValues)
{ {
Vector3 v_neg(-1.0f, -2.0f, -3.0f); constexpr Vector3 v_neg(-1.0f, -2.0f, -3.0f);
Vector3 result = v1 + v_neg; const Vector3 result = v1 + v_neg;
EXPECT_FLOAT_EQ(result.x, 0.0f); EXPECT_FLOAT_EQ(result.x, 0.0f);
EXPECT_FLOAT_EQ(result.y, 0.0f); EXPECT_FLOAT_EQ(result.y, 0.0f);
EXPECT_FLOAT_EQ(result.z, 0.0f); EXPECT_FLOAT_EQ(result.z, 0.0f);
@@ -371,8 +371,8 @@ TEST_F(UnitTestVector3, Addition_NegativeValues)
TEST_F(UnitTestVector3, Subtraction_NegativeValues) TEST_F(UnitTestVector3, Subtraction_NegativeValues)
{ {
Vector3 v_neg(-1.0f, -2.0f, -3.0f); constexpr Vector3 v_neg(-1.0f, -2.0f, -3.0f);
Vector3 result = v1 - v_neg; const Vector3 result = v1 - v_neg;
EXPECT_FLOAT_EQ(result.x, 2.0f); EXPECT_FLOAT_EQ(result.x, 2.0f);
EXPECT_FLOAT_EQ(result.y, 4.0f); EXPECT_FLOAT_EQ(result.y, 4.0f);
EXPECT_FLOAT_EQ(result.z, 6.0f); EXPECT_FLOAT_EQ(result.z, 6.0f);
@@ -381,7 +381,7 @@ TEST_F(UnitTestVector3, Subtraction_NegativeValues)
// Test AsTuple method // Test AsTuple method
TEST_F(UnitTestVector3, AsTuple) TEST_F(UnitTestVector3, AsTuple)
{ {
auto tuple = v1.AsTuple(); const auto tuple = v1.AsTuple();
EXPECT_FLOAT_EQ(std::get<0>(tuple), v1.x); EXPECT_FLOAT_EQ(std::get<0>(tuple), v1.x);
EXPECT_FLOAT_EQ(std::get<1>(tuple), v1.y); EXPECT_FLOAT_EQ(std::get<1>(tuple), v1.y);
EXPECT_FLOAT_EQ(std::get<2>(tuple), v1.z); EXPECT_FLOAT_EQ(std::get<2>(tuple), v1.z);