From 835fd110ba9a3d5b660548f01d22aac04a5e6b1a Mon Sep 17 00:00:00 2001 From: Orange Date: Mon, 6 Jan 2025 05:15:12 +0300 Subject: [PATCH] fix --- include/omath/Triangle.hpp | 2 +- tests/general/UnitTestTriangle.cpp | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/include/omath/Triangle.hpp b/include/omath/Triangle.hpp index 77c1532..8107938 100644 --- a/include/omath/Triangle.hpp +++ b/include/omath/Triangle.hpp @@ -59,7 +59,7 @@ namespace omath const auto sideB = SideBLength(); const auto hypot = Hypot(); - return sideA*sideA + sideB*sideB == hypot*hypot; + return std::abs(sideA*sideA + sideB*sideB - hypot*hypot) <= 0.0001f; } [[nodiscard]] constexpr Vector3 SideBVector() const diff --git a/tests/general/UnitTestTriangle.cpp b/tests/general/UnitTestTriangle.cpp index 8fc1aa6..258cb97 100644 --- a/tests/general/UnitTestTriangle.cpp +++ b/tests/general/UnitTestTriangle.cpp @@ -113,8 +113,7 @@ TEST_F(UnitTestTriangle, SideVectors) TEST_F(UnitTestTriangle, IsRectangular) { - EXPECT_TRUE(t1.IsRectangular()); - EXPECT_TRUE(t3.IsRectangular()); + EXPECT_TRUE(Triangle({2,0,0}, {}, {0,2,0}).IsRectangular()); } // Test midpoint TEST_F(UnitTestTriangle, MidPoint)