unit tests buid off by defalut

CMakeLists.txt

@@ -5,7 +5,7 @@ project(omath VERSION 1.0.1 LANGUAGES CXX)
 include(CMakePackageConfigHelpers)
 
 
-option(OMATH_BUILD_TESTS "Build unit tests" ON)
+option(OMATH_BUILD_TESTS "Build unit tests" OFF)
 option(OMATH_THREAT_WARNING_AS_ERROR "Set highest level of warnings and force compiler to treat them as errors" ON)
 option(OMATH_BUILD_AS_SHARED_LIBRARY "Build Omath as .so or .dll" OFF)
 option(OMATH_USE_AVX2 "Omath will use AVX2 to boost performance" ON)

include/omath/Angle.hpp

@@ -19,7 +19,7 @@ namespace omath
     class Angle
     {
         Type m_angle;
-        constexpr Angle(const Type& degrees)
+        constexpr explicit Angle(const Type& degrees)
         {
             if constexpr (flags == AngleFlags::Normalized)
                 m_angle = angles::WrapAngle(degrees, min, max);
@@ -36,7 +36,7 @@ namespace omath
         [[nodiscard]]
         constexpr static Angle FromDegrees(const Type& degrees)
         {
-            return {degrees};
+            return Angle{degrees};
         }
         constexpr Angle() : m_angle(0)
         {
@@ -45,7 +45,7 @@ namespace omath
         [[nodiscard]]
         constexpr static Angle FromRadians(const Type& degrees)
         {
-            return {angles::RadiansToDegrees<Type>(degrees)};
+            return Angle{angles::RadiansToDegrees<Type>(degrees)};
         }
 
         [[nodiscard]]
@@ -146,7 +146,7 @@ namespace omath
         [[nodiscard]]
         constexpr Angle operator-() const
         {
-            return {-m_angle};
+            return Angle{-m_angle};
         }
     };
 }

include/omath/Mat.hpp

@@ -34,11 +34,13 @@ namespace omath
     class Mat final
     {
     public:
-        constexpr Mat()
+        constexpr Mat() noexcept
         {
             Clear();
         }
-        constexpr static MatStoreType GetStoreOrdering()
+
+        [[nodiscard]]
+        constexpr static MatStoreType GetStoreOrdering() noexcept
         {
             return StoreType;
         }
@@ -72,6 +74,7 @@ namespace omath
             m_data = other.m_data;
         }
 
+        [[nodiscard]]
         constexpr Type& operator[](const size_t row, const size_t col)
         {
             return At(row, col);
@@ -100,7 +103,8 @@ namespace omath
             return {Rows, Columns};
         }
 
-        [[nodiscard]] constexpr const Type& At(const size_t rowIndex, const size_t columnIndex) const
+        [[nodiscard]]
+        constexpr const Type& At(const size_t rowIndex, const size_t columnIndex) const
         {
             if (rowIndex >= Rows || columnIndex >= Columns)
                 throw std::out_of_range("Index out of range");
@@ -177,6 +181,7 @@ namespace omath
             return *this = *this * other;
         }
 
+        [[nodiscard]]
         constexpr Mat operator*(const Type& f) const noexcept
         {
             Mat result(*this);
@@ -192,6 +197,7 @@ namespace omath
             return *this;
         }
 
+        [[nodiscard]]
         constexpr Mat operator/(const Type& f) const noexcept
         {
             Mat result(*this);

include/omath/Triangle.hpp

@@ -6,6 +6,16 @@
 
 namespace omath
 {
+        /*
+        |\
+        | \
+      a |  \ hypot
+        |   \
+        -----
+          b
+        */
+
+
     template<class Vector>
     class Triangle final
     {

include/omath/Vector3.hpp

@@ -110,45 +110,45 @@ namespace omath
             return *this;
         }
 
-        [[nodiscard]] constexpr float DistToSqr(const Vector3& vOther) const
+        [[nodiscard]] constexpr Type DistToSqr(const Vector3& vOther) const
         {
             return (*this - vOther).LengthSqr();
         }
 
-        [[nodiscard]] constexpr float Dot(const Vector3& vOther) const
+        [[nodiscard]] constexpr Type Dot(const Vector3& vOther) const
         {
             return Vector2<Type>::Dot(vOther) + z * vOther.z;
         }
 
 #ifndef _MSC_VER
-        [[nodiscard]] constexpr float Length() const
+        [[nodiscard]] constexpr Type Length() const
         {
             return std::hypot(x, y, z);
         }
 
-        [[nodiscard]] constexpr float Length2D() const
+        [[nodiscard]] constexpr Type Length2D() const
         {
             return Vector2::Length();
         }
-        [[nodiscard]] float DistTo(const Vector3& vOther) const
+        [[nodiscard]] Type DistTo(const Vector3& vOther) const
         {
             return (*this - vOther).Length();
         }
         [[nodiscard]] constexpr Vector3 Normalized() const
         {
-            const float length = this->Length();
+            const Type length = this->Length();
 
             return length != 0 ? *this / length : *this;
         }
 #else
-        [[nodiscard]] float Length() const
+        [[nodiscard]] Type Length() const
         {
             return std::hypot(this->x, this->y, z);
         }
 
         [[nodiscard]] Vector3 Normalized() const
         {
-            const float length = this->Length();
+            const Type length = this->Length();
 
             return length != 0 ? *this / length : *this;
         }
@@ -158,14 +158,14 @@ namespace omath
             return Vector2<Type>::Length();
         }
 
-        [[nodiscard]] float DistTo(const Vector3& vOther) const
+        [[nodiscard]] Type DistTo(const Vector3& vOther) const
         {
             return (*this - vOther).Length();
         }
 #endif
 
 
-        [[nodiscard]] constexpr float LengthSqr() const
+        [[nodiscard]] constexpr Type LengthSqr() const
         {
             return Vector2<Type>::LengthSqr() + z * z;
         }
@@ -214,7 +214,7 @@ namespace omath
                 this->x * v.y - this->y * v.x
             };
         }
-        [[nodiscard]] constexpr float Sum() const
+        [[nodiscard]] constexpr Type Sum() const
         {
             return Sum2D() + z;
         }
@@ -238,12 +238,12 @@ namespace omath
             return false;
         }
 
-        [[nodiscard]] constexpr float Sum2D() const
+        [[nodiscard]] constexpr Type Sum2D() const
         {
             return Vector2<Type>::Sum();
         }
 
-        [[nodiscard]] constexpr std::tuple<float, float, float> AsTuple() const
+        [[nodiscard]] constexpr std::tuple<Type, Type, Type> AsTuple() const
         {
             return std::make_tuple(this->x, this->y, z);
         }

include/omath/Vector4.hpp

@@ -81,7 +81,7 @@ namespace omath
             return Vector3<Type>::LengthSqr() + w * w;
         }
 
-        [[nodiscard]] constexpr float Dot(const Vector4& vOther) const
+        [[nodiscard]] constexpr Type Dot(const Vector4& vOther) const
         {
             return Vector3<Type>::Dot(vOther) + w * vOther.w;
         }
@@ -98,7 +98,7 @@ namespace omath
 
             return *this;
         }
-        constexpr Vector4& Clamp(const float min, const float max)
+        constexpr Vector4& Clamp(const Type& min, const Type& max)
         {
             this->x = std::clamp(this->x, min, max);
             this->y = std::clamp(this->y, min, max);
@@ -126,7 +126,7 @@ namespace omath
         }
 
         [[nodiscard]]
-        constexpr Vector4 operator*(const float scalar) const
+        constexpr Vector4 operator*(const Type& scalar) const
         {
             return {this->x * scalar, this->y * scalar, this->z * scalar, w * scalar};
         }
@@ -138,7 +138,7 @@ namespace omath
         }
 
         [[nodiscard]]
-        constexpr Vector4 operator/(const float scalar) const
+        constexpr Vector4 operator/(const Type& scalar) const
         {
             return {this->x / scalar, this->y / scalar, this->z / scalar, w / scalar};
         }

include/omath/projection/Camera.hpp

@@ -38,7 +38,7 @@ namespace omath::projection
         {
 
         }
-
+    protected:
         virtual void LookAt(const Vector3<float>& target) = 0;
 
         [[nodiscard]] virtual Mat4x4Type CalcViewMatrix() const = 0;
@@ -49,41 +49,44 @@ namespace omath::projection
         {
             return CalcProjectionMatrix() * CalcViewMatrix();
         }
+    public:
+
+        [[nodiscard]] const Mat4x4Type& GetViewProjectionMatrix() const
+        {
+            if (!m_viewProjectionMatrix.has_value())
+                m_viewProjectionMatrix = CalcViewProjectionMatrix();
+
+            return m_viewProjectionMatrix.value();
+        }
 
         void SetFieldOfView(const FieldOfView& fov)
         {
             m_fieldOfView = fov;
-            m_viewProjectionMatrix = CalcViewProjectionMatrix();
         }
 
         void SetNearPlane(const float near)
         {
             m_nearPlaneDistance = near;
-            m_viewProjectionMatrix = CalcViewProjectionMatrix();
         }
 
         void SetFarPlane(const float far)
         {
             m_farPlaneDistance = far;
-            m_viewProjectionMatrix = CalcViewProjectionMatrix();
         }
 
         void SetViewAngles(const ViewAnglesType& viewAngles)
         {
             m_viewAngles = viewAngles;
-            m_viewProjectionMatrix = CalcViewProjectionMatrix();
         }
 
         void SetOrigin(const Vector3<float>& origin)
         {
             m_origin = origin;
-            m_viewProjectionMatrix = CalcViewProjectionMatrix();
         }
 
         void SetViewPort(const ViewPort& viewPort)
         {
             m_viewPort = viewPort;
-            m_viewProjectionMatrix = CalcViewProjectionMatrix();
         }
 
         [[nodiscard]] const FieldOfView& GetFieldOfView() const
@@ -113,10 +116,9 @@ namespace omath::projection
 
         [[nodiscard]] std::expected<Vector3<float>, Error> WorldToScreen(const Vector3<float>& worldPosition) const
         {
-            if (!m_viewProjectionMatrix.has_value())
-                m_viewProjectionMatrix = CalcViewProjectionMatrix();
+            const auto& viewProjMatrix = GetViewProjectionMatrix();
 
-            auto projected = m_viewProjectionMatrix.value() * MatColumnFromVector<float, Mat4x4Type::GetStoreOrdering()>(worldPosition);
+            auto projected = viewProjMatrix * MatColumnFromVector<float, Mat4x4Type::GetStoreOrdering()>(worldPosition);
 
             if (projected.At(3, 0) == 0.0f)
                 return std::unexpected(Error::WORLD_POSITION_IS_OUT_OF_SCREEN_BOUNDS);

source/projectile_prediction/ProjPredEngineAVX2.cpp

@@ -108,8 +108,8 @@ namespace omath::projectile_prediction
     }
     ProjPredEngineAVX2::ProjPredEngineAVX2(const float gravityConstant, const float simulationTimeStep,
                                            const float maximumSimulationTime) :
-        m_gravityConstant(gravityConstant), m_simulationTimeStep(maximumSimulationTime),
-        m_maximumSimulationTime(simulationTimeStep)
+        m_gravityConstant(gravityConstant), m_simulationTimeStep(simulationTimeStep),
+        m_maximumSimulationTime(maximumSimulationTime)
     {
     }
     std::optional<float> ProjPredEngineAVX2::CalculatePitch(const Vector3<float>& projOrigin,