mirror of
https://github.com/orange-cpp/omath.git
synced 2026-04-23 13:23:27 +00:00
+90 up -90 down fix for camera view angles
This commit is contained in:
@@ -32,7 +32,7 @@ namespace omath::unreal_engine
|
||||
{
|
||||
return mat_rotation_axis_x<float, MatStoreType::ROW_MAJOR>(angles.roll)
|
||||
* mat_rotation_axis_z<float, MatStoreType::ROW_MAJOR>(angles.yaw)
|
||||
* mat_rotation_axis_y<float, MatStoreType::ROW_MAJOR>(angles.pitch);
|
||||
* mat_rotation_axis_y<float, MatStoreType::ROW_MAJOR>(-angles.pitch);
|
||||
}
|
||||
Mat4X4 calc_perspective_projection_matrix(const float field_of_view, const float aspect_ratio, const float near,
|
||||
const float far, const NDCDepthRange ndc_depth_range) noexcept
|
||||
|
||||
@@ -10,7 +10,7 @@ namespace omath::unreal_engine
|
||||
{
|
||||
const auto direction = (look_at - cam_origin).normalized();
|
||||
|
||||
return {PitchAngle::from_radians(-std::asin(direction.z)),
|
||||
return {PitchAngle::from_radians(std::asin(direction.z)),
|
||||
YawAngle::from_radians(std::atan2(direction.y, direction.x)), RollAngle::from_radians(0.f)};
|
||||
}
|
||||
Mat4X4 CameraTrait::calc_view_matrix(const ViewAngles& angles, const Vector3<float>& cam_origin) noexcept
|
||||
|
||||
@@ -32,7 +32,7 @@ TEST(unit_test_unreal_engine, ForwardVectorRotationPitch)
|
||||
{
|
||||
omath::unreal_engine::ViewAngles angles;
|
||||
|
||||
angles.pitch = omath::unreal_engine::PitchAngle::from_degrees(-90.f);
|
||||
angles.pitch = omath::unreal_engine::PitchAngle::from_degrees(90.f);
|
||||
|
||||
const auto forward = omath::unreal_engine::forward_vector(angles);
|
||||
EXPECT_NEAR(forward.x, omath::unreal_engine::k_abs_up.x, 0.00001f);
|
||||
|
||||
Reference in New Issue
Block a user