improvement

examples/example_dx11_hook/dllmain.cpp

@@ -5,6 +5,7 @@
 #include <imgui.h>
 #include <imgui_impl_dx11.h>
 #include <imgui_impl_win32.h>
+#include <thread>
 #include <tuple>
 
 extern IMGUI_IMPL_API LRESULT ImGui_ImplWin32_WndProcHandler(HWND, UINT, WPARAM, LPARAM);
@@ -18,6 +19,7 @@ namespace
     ID3D11DeviceContext* g_context = nullptr;
     ID3D11RenderTargetView* g_render_target_view = nullptr;
 
+    [[nodiscard]]
     bool create_render_target(IDXGISwapChain* swap_chain)
     {
         ID3D11Texture2D* back_buffer = nullptr;
@@ -58,9 +60,9 @@ namespace
         g_device->GetImmediateContext(&g_context);
 
         DXGI_SWAP_CHAIN_DESC desc{};
-        swap_chain->GetDesc(&desc);
+        std::ignore = swap_chain->GetDesc(&desc);
 
-        create_render_target(swap_chain);
+        std::ignore = create_render_target(swap_chain);
 
         ImGui::CreateContext();
         ImGui::StyleColorsDark();
@@ -73,7 +75,7 @@ namespace
 
         auto& mgr = omath::hooks::HooksManager::get();
         mgr.set_on_wnd_proc(
-                [](HWND h, UINT msg, WPARAM wp, LPARAM lp) -> std::optional<LRESULT>
+                [](const HWND h, const UINT msg, const WPARAM wp, const LPARAM lp) -> std::optional<LRESULT>
                 {
                     if (ImGui_ImplWin32_WndProcHandler(h, msg, wp, lp))
                         return 0;
@@ -106,13 +108,8 @@ namespace
         ImGui_ImplDX11_NewFrame();
         ImGui_ImplWin32_NewFrame();
         ImGui::NewFrame();
-
-        ImGui::SetNextWindowSize({300.f, 80.f}, ImGuiCond_Once);
-        ImGui::SetNextWindowPos({10.f, 10.f}, ImGuiCond_Once);
-        ImGui::Begin("omath | DX11 hook");
-        ImGui::Text("Hook active");
-        ImGui::Text("FPS: %.1f", ImGui::GetIO().Framerate);
-        ImGui::End();
+        ImGui::GetIO().MouseDrawCursor = true;
+        ImGui::ShowDemoWindow();
 
         ImGui::Render();
         ImGui_ImplDX11_RenderDrawData(ImGui::GetDrawData());
@@ -134,14 +131,13 @@ namespace
     }
 } // namespace
 
-BOOL WINAPI DllMain(HINSTANCE h_instance, DWORD reason, LPVOID)
+BOOL WINAPI DllMain(const HINSTANCE h_instance, const DWORD reason, LPVOID)
 {
     if (reason == DLL_PROCESS_ATTACH)
     {
         DisableThreadLibraryCalls(h_instance);
-        CreateThread(
-                nullptr, 0,
-                [](LPVOID) -> DWORD
+        std::thread(
+                []()
                 {
                     while (!GetModuleHandle("d3d11.dll"))
                         Sleep(100);
@@ -151,8 +147,8 @@ BOOL WINAPI DllMain(HINSTANCE h_instance, DWORD reason, LPVOID)
                     mgr.set_on_resize_buffers(on_resize_buffers);
                     std::ignore = mgr.hook_dx11();
                     return 0;
-                },
-                nullptr, 0, nullptr);
+                })
+                .detach();
     }
     else if (reason == DLL_PROCESS_DETACH)
     {

examples/example_dx12_hook/dllmain.cpp

@@ -449,9 +449,8 @@ BOOL WINAPI DllMain(HINSTANCE h_instance, DWORD reason, LPVOID)
     if (reason == DLL_PROCESS_ATTACH)
     {
         DisableThreadLibraryCalls(h_instance);
-        CreateThread(
-                nullptr, 0,
-                [](LPVOID) -> DWORD
+        std::thread(
+                []()
                 {
                     while (!GetModuleHandle("d3d12.dll"))
                         Sleep(100);
@@ -462,8 +461,8 @@ BOOL WINAPI DllMain(HINSTANCE h_instance, DWORD reason, LPVOID)
                     mgr.set_on_execute_command_lists(on_execute_command_lists);
                     std::ignore = mgr.hook_dx12();
                     return 0;
-                },
-                nullptr, 0, nullptr);
+                })
+                .detach();
     }
     else if (reason == DLL_PROCESS_DETACH)
     {

examples/example_dx9_hook/dllmain.cpp

@@ -1,11 +1,10 @@
+#include "omath/hooks/hooks_manager.hpp"
 #include <Windows.h>
 #include <d3d9.h>
 #include <imgui.h>
 #include <imgui_impl_dx9.h>
 #include <imgui_impl_win32.h>
 
-#include "omath/hooks/hooks_manager.hpp"
-
 extern IMGUI_IMPL_API LRESULT ImGui_ImplWin32_WndProcHandler(HWND, UINT, WPARAM, LPARAM);
 
 namespace
@@ -31,12 +30,14 @@ namespace
         ImGui_ImplDX9_Init(device);
 
         auto& mgr = omath::hooks::HooksManager::get();
-        mgr.set_on_wnd_proc([](HWND h, UINT msg, WPARAM wp, LPARAM lp) -> std::optional<LRESULT> {
+        mgr.set_on_wnd_proc(
+                [](HWND h, UINT msg, WPARAM wp, LPARAM lp) -> std::optional<LRESULT>
+                {
                     if (ImGui_ImplWin32_WndProcHandler(h, msg, wp, lp))
                         return 0;
                     return std::nullopt;
                 });
-        mgr.hook_wnd_proc(params.hFocusWindow);
+        std::ignore = mgr.hook_wnd_proc(params.hFocusWindow);
 
         g_initialized = true;
     }
@@ -54,11 +55,8 @@ namespace
         ImGui_ImplWin32_NewFrame();
         ImGui::NewFrame();
 
-        ImGui::SetNextWindowSize({300.f, 80.f}, ImGuiCond_Once);
-        ImGui::SetNextWindowPos({10.f, 10.f}, ImGuiCond_Once);
-        ImGui::Begin("omath | DX9 hook");
-        ImGui::Text("Hook active");
-        ImGui::Text("FPS: %.1f", ImGui::GetIO().Framerate);
+        ImGui::GetIO().MouseDrawCursor = true;
+        ImGui::ShowDemoWindow();
         ImGui::End();
 
         ImGui::EndFrame();
@@ -78,7 +76,8 @@ BOOL WINAPI DllMain(HINSTANCE h_instance, DWORD reason, LPVOID)
     if (reason == DLL_PROCESS_ATTACH)
     {
         DisableThreadLibraryCalls(h_instance);
-        CreateThread(nullptr, 0, [](LPVOID) -> DWORD
+        std::thread(
+                []()
                 {
                     while (!GetModuleHandle("d3d9.dll"))
                         Sleep(100);
@@ -86,9 +85,10 @@ BOOL WINAPI DllMain(HINSTANCE h_instance, DWORD reason, LPVOID)
                     auto& mgr = omath::hooks::HooksManager::get();
                     mgr.set_on_dx9_present(on_present);
                     mgr.set_on_dx9_reset(on_reset);
-            mgr.hook_dx9();
+                    std::ignore = mgr.hook_dx9();
                     return 0;
-        }, nullptr, 0, nullptr);
+                })
+                .detach();
     }
     else if (reason == DLL_PROCESS_DETACH)
     {